Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes annotation and introduce tabs for static-client spec #21199

Merged
merged 1 commit into from
May 22, 2024
Merged

Fixes annotation and introduce tabs for static-client spec #21199

merged 1 commit into from
May 22, 2024

Conversation

Ranjandas
Copy link
Contributor

@Ranjandas Ranjandas commented May 22, 2024 •
edited
Loading

Description

The upstream annotation is not required for external services defined using the ServiceDefaults Destinations. Created a Tab that separates the static client spec for ServiceDefaults Destinations and directly registered into catalog scenarios.

Testing & Reproduction steps

Links

Preview: https://consul-git-docs-k8s-terminating-gw-hashicorp.vercel.app/consul/docs/k8s/connect/terminating-gateways#define-the-external-services-as-upstreams-for-services-in-the-mesh

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@Ranjandas
Fixes annotation and introduce tabs for static-client spec
4e35325 
The upstream annotation is not required for external services defined
using the ServiceDefaults Destinations.
@Ranjandas Ranjandas added type/docs Documentation needs to be created/updated/clarified pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. backport/1.18 backport/ent/1.17 This release series is longer active on CE or Ent labels May 22, 2024
@Ranjandas Ranjandas requested a review from a team as a code owner May 22, 2024 06:59
@Ranjandas Ranjandas added pr/no-changelog PR does not need a corresponding .changelog entry and removed pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. labels May 22, 2024
@Ranjandas
Copy link
Contributor Author

Thank you @blake.

@Ranjandas Ranjandas merged commit b2a618b into main May 22, 2024
100 of 106 checks passed
@Ranjandas Ranjandas deleted the docs/k8s-terminating-gw branch May 22, 2024 21:27
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request May 22, 2024
Merged
4 tasks
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@zalimeni zalimeni added the backport/1.18 This release series is longer active on CE, use backport/ent/1.18 label May 28, 2024
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

6 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@zalimeni zalimeni added backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. and removed backport/ent/1.17 This release series is longer active on CE or Ent labels Jun 4, 2024
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

28 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@Ranjandas, a backport is missing for this PR [21199] for versions [1.15,1.16] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blake blake blake approved these changes

Assignees
No one assigned
Labels
backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. backport/1.18 This release series is longer active on CE, use backport/ent/1.18 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ranjandas @hc-github-team-consul-core @blake @zalimeni