Backport of fix(txn): validate verbs into release/1.19.x #21520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/dans/NET-9159/panic-on-fsm-error-two/amazingly-full-earwig
branch
from
3f5e18c
to
532b294
Compare
github-team-consul-core-pr-approver
approved these changes
Jul 5, 2024
DanStough
deleted the
backport/dans/NET-9159/panic-on-fsm-error-two/amazingly-full-earwig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21519 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
There are two entry points into the state store:
In the latter case, errors are not acknowledged because the log must be processed by Consul. It is possible in this case that if a future version of Consul is using syntax, such as Txn API Verbs, that the current version does not understand, it will fail to apply successfully, causing a divergence with other servers.
This PR makes two types of changes:
Overview of commits