Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supression #21744

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fix supression #21744

merged 2 commits into from
Sep 16, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Suppression statement was under binary and not container

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@sarahalsmiller sarahalsmiller requested a review from a team as a code owner September 16, 2024 17:57
@sarahalsmiller sarahalsmiller added pr/no-changelog PR does not need a corresponding .changelog entry backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 16, 2024
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) September 16, 2024 17:57
@sarahalsmiller sarahalsmiller merged commit 17d43c6 into main Sep 16, 2024
94 checks passed
@sarahalsmiller sarahalsmiller deleted the fix-supression-statement branch September 16, 2024 18:43
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 16, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 16, 2024
Merged
4 tasks
sarahalsmiller added a commit that referenced this pull request Sep 16, 2024
@sarahalsmiller
Fix supression (#21744)
032d3e4 
fix supression
sarahalsmiller added a commit that referenced this pull request Sep 16, 2024
@hc-github-team-consul-core @sarahalsmiller
Backport of Fix supression into release/1.19.x (#21745)
dda31b8 
* no-op commit due to failed cherry-picking

* Fix supression (#21744)

fix supression

---------

Co-authored-by: temp <temp@hashicorp.com>
Co-authored-by: sarahalsmiller <100602640+sarahalsmiller@users.noreply.github.com>
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @sarahalsmiller! a backport is missing for this PR [21744] for versions [1.15,1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

@zalimeni zalimeni zalimeni approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarahalsmiller @hc-github-team-consul-core @zalimeni @dduzgun-security