-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize 1.20 Release #21746
Initialize 1.20 Release #21746
Conversation
@@ -6,6 +6,9 @@ | |||
|
|||
schema = 1 | |||
active_versions { | |||
version "1.20" { | |||
ce_active = true | |||
}, | |||
version "1.19" { | |||
ce_active = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd need to remove the ce_active
from this line correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The engineering release documents explicitly state not to remove the ce_active line from the previous version at this stage, as that will happen in a post-release stage. I'd have thought so too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, think we need to remove the comma at the end of that block (BPA is unhappy about it): #21752
Mostly commenting in case of future copypasta PRs - at least that's how I often remind myself of release steps 😄
93c84df
to
6ab7ec2
Compare
@sarahalsmiller FYI, I removed and re-added the (At first I thought we didn't need to backport this change, then I noticed the VERSION file update, which is needed in 1.20.x) |
Description
Creating release to initialize 1.20 version as specified in this document