Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize 1.20 Release #21746

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Initialize 1.20 Release #21746

merged 7 commits into from
Sep 16, 2024

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented Sep 16, 2024

Description

Creating release to initialize 1.20 version as specified in this document

@sarahalsmiller sarahalsmiller added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Sep 16, 2024
@sarahalsmiller sarahalsmiller requested a review from a team as a code owner September 16, 2024 20:11
@sarahalsmiller sarahalsmiller added backport/1.20 Changes are backported to 1.20 and removed pr/no-backport labels Sep 16, 2024
@@ -6,6 +6,9 @@

schema = 1
active_versions {
version "1.20" {
ce_active = true
},
version "1.19" {
ce_active = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd need to remove the ce_active from this line correct?

Copy link
Member Author

@sarahalsmiller sarahalsmiller Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The engineering release documents explicitly state not to remove the ce_active line from the previous version at this stage, as that will happen in a post-release stage. I'd have thought so too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-16 at 3 37 09 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, think we need to remove the comma at the end of that block (BPA is unhappy about it): #21752

Mostly commenting in case of future copypasta PRs - at least that's how I often remind myself of release steps 😄

@sarahalsmiller sarahalsmiller enabled auto-merge (squash) September 16, 2024 21:43
@sarahalsmiller sarahalsmiller merged commit e0785bc into main Sep 16, 2024
94 checks passed
@sarahalsmiller sarahalsmiller deleted the init-1.20-release-branch branch September 16, 2024 22:06
@zalimeni zalimeni added backport/1.20 Changes are backported to 1.20 and removed backport/1.20 Changes are backported to 1.20 labels Sep 17, 2024
@zalimeni
Copy link
Member

zalimeni commented Sep 17, 2024

@sarahalsmiller FYI, I removed and re-added the backport/1.20 to kick the backport off using the latest versions.hcl

(At first I thought we didn't need to backport this change, then I noticed the VERSION file update, which is needed in 1.20.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants