Switches to reliable Raft leader notifications. #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2896 by switching to the `notifyCh` instead of the `leaderCh`, so we get all up/down events from Raft regarding leadership. We also wait for the old leader loop to shut down before we ever consider starting a new one, which keeps that single-threaded and fixes the panic in that issue.
slackpad
requested review from
armon and
kyhavlov
and removed request for
armon
|
/cc @armon as FYI - this was the change we were chatting about |
|
@armon Yeah this is tracked for 0.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2896 by switching to the
notifyChinstead of theleaderCh, so we get all up/down events from Raft regarding leadership. We also wait for the old leader loop to shut down before we ever consider starting a new one, which keeps that single-threaded and fixes the panic in that issue.