Fixes panic in tombstone GC. #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magiconair
reviewed
Apr 27, 2017
consul/state/tombstone_gc_test.go
Outdated
| t.Fatalf("err: %v", err) | ||
| } | ||
|
|
||
| for i := 0; i < 1000; i++ { |
There was a problem hiding this comment.
What does this test? Why 1000? What is the failure condition?
There was a problem hiding this comment.
This would repro the panic, but probably isn't useful as an ongoing unit test since it's not super deterministic (I had to push it up to 1000 to get it to fail). I'll remove it.
consul/state/tombstone_gc.go
Outdated
| expireCh chan uint64 | ||
|
|
||
| // lock is used to ensure safe access to all the fields | ||
| // lock is used to ensure safe access to all the fields. |
There was a problem hiding this comment.
If lock guards everything then you can embed sync.Mutex
|
I think you can also drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2087 and closes #2582.