Return 403 rather than a 404 when acls cause all results to be filter… #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed out. This fixes #2637
slackpad
approved these changes
Jul 31, 2017
agent/consul/filter.go
Outdated
| return ent[:FilterEntries(&df)] | ||
| filtered := ent[:FilterEntries(&df)] | ||
| if len(filtered) == 0 { | ||
| return filtered, errPermissionDenied |
There was a problem hiding this comment.
For all of these cases I'd return nil, errPermissionDenied, just to make it stand out that the filtered results aren't usable. It'll work the same way, but this makes it clear.
…ror, updated unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed out. This fixes #2637