Respect udp_answer_limit parameter even if UDP payload size is not 512 #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hashicorp#3355 Change-Id: I3f6893224776d064b920ada9e1bf7e0fc58805ab Signed-off-by: Grégoire Seux <g.seux@criteo.com>
|
Can you add a test for this, please? |
|
@sethvargo this was introduced in a8f1e7e as part of #3131. You might want to have a look. |
sethvargo
reviewed
Aug 10, 2017
| @@ -567,7 +567,7 @@ func trimUDPResponse(config *DNSConfig, req, resp *dns.Msg) (trimmed bool) { | |||
|
|
|||
| // This cuts UDP responses to a useful but limited number of responses. | |||
| maxAnswers := lib.MinInt(maxUDPAnswerLimit, config.UDPAnswerLimit) | |||
| if maxSize == defaultMaxUDPSize && numAnswers > maxAnswers { | |||
| if numAnswers > maxAnswers { | |||
There was a problem hiding this comment.
I think the idea here is that, if request is edns and the size has changed from the default max size, we don't want to trim the answers or else they will be truncated.
There was a problem hiding this comment.
@sethvargo I'm not sure to understand what you mean. Would you have an example?
There was a problem hiding this comment.
I think you can try "+bufsize=512" with dig , because the dig may not build with edns.
|
abandoning this PR, I'll solve our issue with a different mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3355
Signed-off-by: Grégoire Seux g.seux@criteo.com