Change member join reconcile step to process joining itself, to handl… #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e node IP address changes correctly when number of servers < 3
preetapan
commented
Sep 6, 2017
agent/consul/leader.go
Outdated
| @@ -626,8 +626,8 @@ func (s *Server) handleDeregisterMember(reason string, member serf.Member) error | |||
|
|
|||
| // joinConsulServer is used to try to join another consul server | |||
| func (s *Server) joinConsulServer(m serf.Member, parts *metadata.Server) error { | |||
| // Do not join ourself | |||
| if m.Name == s.config.NodeName { | |||
| // Do not join ourself if we are the only member | |||
There was a problem hiding this comment.
If I removed this check entirely, TestAgent_CheckAdvertiseAddrsSettings failed. Seems like it was trying to join the same node id with a different IP address, and if this check went away entirely it would keep removing and adding itself and never finishing leader election.
|
This fixes an issue found testing #1580. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e node IP address changes correctly when number of servers < 3