Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport mitchellh/cli patch for help output #3541

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

magiconair
Copy link
Contributor

This patch backports a fix which will show the correct usage screen for
command line flags.

This is considered a temporary fix until the code has been refactored.
Newer versions of the cli library require that the flag set is populated
when Help() is called or that it is populated within Help() itself.

Fixes #3536

@magiconair magiconair requested a review from slackpad October 5, 2017 15:23
@magiconair magiconair self-assigned this Oct 5, 2017
@magiconair magiconair added this to the 1.0 milestone Oct 5, 2017
This patch backports a fix which will show the correct usage screen for
command line flags.

This is considered a temporary fix until the code has been refactored.
Newer versions of the cli library require that the flag set is populated
when Help() is called or that it is populated within Help() itself.

Fixes #3536
@magiconair magiconair force-pushed the issue-3536-backport-cli-patch branch from 7a2527c to 4405776 Compare October 5, 2017 15:25
Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magiconair magiconair merged commit 3a7fb35 into master Oct 5, 2017
@magiconair magiconair deleted the issue-3536-backport-cli-patch branch October 5, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consul CLI commands don't display detailed help
2 participants