Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in azure go discover provider #3876

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

preetapan
Copy link
Contributor

@preetapan preetapan commented Feb 8, 2018

This fixes #3875

Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preetapan preetapan merged commit dfd484c into master Feb 8, 2018
@preetapan preetapan deleted the go-discover-panic branch February 8, 2018 22:46
michaelw pushed a commit to michaelw/consul that referenced this pull request Feb 27, 2018
Version 1.0.6

* tag 'v1.0.6': (591 commits)
  Release v1.0.6
  Puts tree in release mode for 1.0.6
  Update CHANGELOG.md
  Bumps Go version back down to 1.9.3.
  Updates the change log.
  Fixes a panic on TCP-based DNS lookups.
  Adds a basic INTERNALS.md guide with some pointers into the code.
  Update CHANGELOG.md
  Fix panic in azure go discover provider (hashicorp#3876)
  Bumps the standard retry up.
  Makes Travis build run less parallel.
  Updates the change log.
  Bumps Go version to 1.9.4.
  Puts tree back in dev mode
  Update CHANGELOG
  Bump download version to 1.0.5
  Release v1.0.5
  Puts version in 1.0.5 release mode
  Update CHANGELOG with release date
  Update CHANGELOG.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure: consul cluster start fails during auto discovery
2 participants