Change KV inputs to textareas, also JSON > CODE #4160
Conversation
As the input field was used for KV's it looked like you couldn't save multiline KV's. Changed to textarea so you can see the multilines. Also, JSON is slightly misleading as clicking the toggle doesn't necessarily mean 'I'm going to edit some JSON' it means I want the code editor with syntax highlighting, so renamed the toggle to say 'Code'
| @@ -11,14 +11,14 @@ | |||
| <div> | |||
| <label class="type-toggle"> | |||
| <input type="checkbox" name="json" checked={{if json 'checked' }} onchange={{action 'change'}} /> | |||
| <span>JSON</span> | |||
| <span>Code</span> | |||
There was a problem hiding this comment.
It's still JSON mode though, right? Would there be a reason to input anything other than JSON? I guess it's really wide open though isn't it.
There was a problem hiding this comment.
Yup, the stuff in the KV could be YAML, XML, HCL, TOML, even templates and stuff.
Basically the toggle is to add line numbers and colored syntax highlighting, not 'json editing', I think the best single word for that is just 'Code'. Would be good to think through how we approach some sort of linting for all that in the future. Would be nice to do a 'best guess' and async load the linting code, not sure how successful that would be in reality though, might be too much 'automation', so adding some 'Lint ' buttons/radios might be the way to go.
Addresses #4138
As the input field was used for KV's it looked like you couldn't save
multiline KV's. Changed to textarea so you can see the multilines.
Also, JSON is slightly misleading as clicking the toggle doesn't
necessarily mean 'I'm going to edit some JSON' it means I want the code
editor with syntax highlighting, so renamed the toggle to say 'Code'