command/agent: don't re-parse the flags on reload #4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
This looks good to me.
Just to make sure I understand the reasoning: re-parsing the flags causes extra config files and hcl fragments to get appended to the slices in the Flags struct? Then when building out the Config a config file is loaded multiple times (1 + number of reloads) causing watches within to be appended once for each time the file is processed.
|
Yeah that was the cause, it was making reloadWatches create more and more watches each time it was called. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul was calling
flags.Parseon reload which would cause watches (and potentially other slice fields in the config) to be re-appended each time.Fixes #4179.