Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance / Feature tests #4190

Merged
merged 15 commits into from
Jun 7, 2018
Merged

Acceptance / Feature tests #4190

merged 15 commits into from
Jun 7, 2018

Commits on Jun 1, 2018

  1. Fix tear down click handler problem in tests

    It's not obvious what "the way" to teardown window event handlers is in
    Ember. The datacenter-picker is permanently in the app during usage, but
    in tests I'm assuming it gets added and removed lots.
    
    So when you run the tests, as the tests aren't run in an isolated runner
    the QUnit test runner ends up with a click handler on it, So if you
    click on the test runner one of the tests will fail.
    
    The failure is related to there not being an element with a `.contains`
    method. So this checks that the element is truthy first, i.e. it exists.
    If it doesn't it just bails out.
    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    2caa3e9 View commit details
    Browse the repository at this point in the history
  2. WIP: Feature/acceptance tests

    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    62c8cf0 View commit details
    Browse the repository at this point in the history
  3. Bump

    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    37eb6ef View commit details
    Browse the repository at this point in the history
  4. Move testing bits to hashicorp org, also..

    Go with `rsync` over `cp` for putting the api double into public for the
    moment
    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    6f74fd4 View commit details
    Browse the repository at this point in the history
  5. Remove some pauses

    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    69f5dbb View commit details
    Browse the repository at this point in the history
  6. WIP: Make sure I can get the values I need to calculate sizing

    `rect.top` is zero until the tab panel becomes visible, resize will need
    to be called when the tab is clicked also
    John Cowen committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    8a39b80 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2018

  1. Make sure didAppear and therefore resize is called on change

    Tables need to calculate their sizing depending on other things in the
    DOM. When a table is in a tab panel, some of these things aren't visible
    and therefore some values are zero during `didInsertElement`.
    
    This commit ensures that the resize calc of the table is performed when
    it's parent tab is clicked (and therefore when the table 'appears')
    John Cowen committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    0a15091 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88a3077 View commit details
    Browse the repository at this point in the history
  3. Add some delete testing to KV and ACL

    John Cowen committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    59a1cea View commit details
    Browse the repository at this point in the history
  4. Upgrade consul-api-double

    John Cowen committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    5f1e28a View commit details
    Browse the repository at this point in the history
  5. Add a couple more unit tests for the utils folder

    John Cowen committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    2ef6310 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Tweak vocab

    John Cowen committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    d4363c2 View commit details
    Browse the repository at this point in the history
  2. Make sure KV clicking is tested (WIP)

    John Cowen committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    f5e8b4b View commit details
    Browse the repository at this point in the history
  3. Make this steps file the same as the others...

    WIP: Ideally all of these would go
    John Cowen committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    94bd0db View commit details
    Browse the repository at this point in the history
  4. Remove buts

    John Cowen committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    15b9184 View commit details
    Browse the repository at this point in the history