Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/connect/proxy: ignore check doesn't exist on -register #4314

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

mitchellh
Copy link
Contributor

This is reasonably jank and I'm open to other solutions, but its also simple.

If a check doesn't exist, then we get an error that sounds scarier than it is. This modifies the -register flag on the consul connect proxy subcommand to only output heartbeat errors if they aren't the "check doesn't exist" error. This error is common if the registration fails, but isn't a big deal in itself. We perform anti-entropy in the registration so that the check will always be recreated pretty quickly so this error is not important to us.

I also thought about only calling heartbeat() if register() is succeeding, but not sure if we want to maintain that state or not.

@pearkes pearkes added this to the 1.2.2 milestone Jul 19, 2018
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with assesment - somewhat jank but also not work a much more elaborate fix.

@mitchellh
Copy link
Contributor Author

Agreed, let's just merge it. It just makes logs less loud.

@mitchellh mitchellh merged commit effb170 into master Jul 25, 2018
@mitchellh mitchellh deleted the b-ignore-check branch July 25, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants