command/connect/proxy: ignore check doesn't exist on -register #4314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reasonably jank and I'm open to other solutions, but its also simple.
If a check doesn't exist, then we get an error that sounds scarier than it is. This modifies the
-register
flag on theconsul connect proxy
subcommand to only output heartbeat errors if they aren't the "check doesn't exist" error. This error is common if the registration fails, but isn't a big deal in itself. We perform anti-entropy in the registration so that the check will always be recreated pretty quickly so this error is not important to us.I also thought about only calling heartbeat() if register() is succeeding, but not sure if we want to maintain that state or not.