UI - Show/search by service ids #4387
Conversation
1. In the Services > Services detail page for both healthy and unhealthy nodes, also add searching by Service.ID here 2. In the Nodes > Node detail > [Services] tab only if its different from the Service name, add searching by Service.ID here
| } | ||
| .unhealthy .healthchecked-resource header.with-service a { | ||
| padding-bottom: 25px; | ||
| } |
There was a problem hiding this comment.
Why don't these use placeholder selectors? Doesn't that make these selectors dependent on the name of the class that extends the placeholder and thus sorta defeat the purpose of the placeholder?
There was a problem hiding this comment.
Yeah defo 👍 I'll be splitting them into something like %healthchecked-resource, %unhealthy-resource and %healthy-resource I think. Until yesterday I was in 'tweak-mode', so this will get revisited as part of a larger CSS refactor now I'm back to more 'heavy-handed mode'
| @@ -35,7 +35,7 @@ | |||
| <h2>Healthy Nodes</h2> | |||
| {{#list-collection | |||
| items=healthy | |||
| cell-layout=(percentage-columns-layout healthy.length columns 100) as |item index| | |||
| cell-layout=(percentage-columns-layout healthy.length columns 92) as |item index| | |||
There was a problem hiding this comment.
I noticed the vertical margins between the unhealthy nodes and the healthy nodes where different by 4px (22px vs 26px), so I equalled them up.
Before:
After:
Ideally they'd be the same, which reminds me I need to ask @opihana about the vertical rhythm of everything across the entire app
| @@ -49,12 +50,13 @@ | |||
| <h2>Healthy Nodes</h2> | |||
| {{#list-collection | |||
| items=healthy | |||
| cell-layout=(percentage-columns-layout healthy.length columns 100) as |item index| | |||
| cell-layout=(percentage-columns-layout healthy.length columns 113) as |item index| | |||
There was a problem hiding this comment.
Yup, so similar to the above its to do with maintaining the 22px margin, you have to specify a row height for the DOM recycling scrollers, and as the boxes grew to make room for the Server.ID this number needed to grow also. Would be nice to auto calculate I suppose, but its a bit 'chicken and egg' 🐔 🥚 (gotta love an emoji 😄 )
| s: service-0-with-id | ||
| --- | ||
| And I see 1 [Model] model | ||
| And I see 1 [Model] model with the id "service-0-with-id" |
There was a problem hiding this comment.
Is this ID hardcoded in the API double?
There was a problem hiding this comment.
Show Service.ID's throughout the app, allow searching by Service.ID
nodes, also add searching by Service.ID here
Before:
After:
from the Service name, add searching by Service.ID here
Before:
After:
Fixes: #4153