Fix issue with choosing a client addr that is 0.0.0.0 or :: #4403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issue where using the default client address of 0.0.0.0 or a custom one of :: will cause watch plans and managed proxies not to communicate correctly back with the agents HTTP api.
Extra logic was added into the RuntimeConfig class to generate a set of client addresses and in the process convert 0.0.0.0 -> 127.0.0.1 and :: -> ::1.
In addition to the extra tests which cover the default cases of having a client address of 0.0.0.0 or :: some manual test I did included.