UI: Switch to fullscreen layout for lists and detail, left aligned forms #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
changed the title
|
Have you given any thought to a narrow layout for forms? I've been thinking about that for Vault since we've got so many forms that are awkwardly wide, and I'm trying to think through options and I'm not sure how I feel about the left aligned forms like in your example |
|
Hey @joshuaogle ! Nice gif 😂 . This is part 1 of a change to the entire layout of the app. Currently we've kept the forms the same width as previously - but left aligned them. The next step is probably going to be a 2 pane layout for average screensizes and above, whilst sticking to a single pane for lower than average screensizes. Ta, |
hannahhearth
approved these changes
Jul 24, 2018
|
P.S. Addresses parts of #4116 |
DingoEatingFuzz
approved these changes
Aug 7, 2018
johncowen
added a commit
that referenced
this pull request
Aug 29, 2018
* Begin refactoring CSS into component folders. Moved most components into layout/skin folders, left out a couple of ones I want to think about more. * Adjust grays based on recent Structure changes * Switch to fullscreen layout for lists and detail, left aligned forms (#4435) * Specifically use the 'actions_close' label, not just the :last-child (actions-group) * Replace some non-var-ed colours in vaults code skin, plus prefixing (black and white)
johncowen
added a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists use the entire available area by removing the left and right white areas on larger screens.
Forms remain the same width yet left aligned.
Navigation and footer will now span the entire viewport area for all layouts.
Listing Before:
Listing After:
Form Before:
Form After: