Allow config-file based Service Definitions for unmanaged proxies #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Connect-natice apps.
banks
changed the title
banks
changed the title
mitchellh
approved these changes
Jul 25, 2018
| @@ -357,7 +359,9 @@ type CheckDefinition struct { | |||
|
|
|||
| // ServiceConnect is the connect block within a service registration | |||
| type ServiceConnect struct { | |||
| // TODO(banks) add way to specify that the app is connect-native | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4417
We forgot to add plumbing to config to allow these Service Definitions to exist in config files as well as API calls.
Updated docs to be comprehensive again although in general we already documented these fields as working!