Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross compiling with make #4445

Merged
merged 1 commit into from
Jul 26, 2018
Merged

Fix cross compiling with make #4445

merged 1 commit into from
Jul 26, 2018

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jul 25, 2018

make XC_OS=linux XC_ARCH=amd64 when running on macos puts its binaries in ${GOPATH}/bin/linux_amd64/consul and not ${GOPATH}/bin/consul

This makes the build pull the binary from the right location.

This was also causing the default make which would build all platforms when CONSUL_DEV wasn't set to copy the compilation platform binary to all of the pkg/bin/* directories.

make XC_OS=linux XC_ARCH=amd64 when running on macos puts its binaries in ${GOPATH}/bin/linux_amd64/consul and not ${GOPATH}/bin/consul

This makes the build pull the binary from the right location.
@mkeeler mkeeler requested a review from MagnumOpus21 July 25, 2018 19:22
Copy link
Contributor

@MagnumOpus21 MagnumOpus21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkeeler mkeeler merged commit c45e19b into master Jul 26, 2018
@mkeeler mkeeler deleted the bugfix/build-cross-compile branch September 6, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants