-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Weights Data structures #4468
Changes from 1 commit
dac209a
6321851
dff7d78
f7a56b3
2dbefc0
a66bfb4
fc03eae
4f23895
99e6b19
25eae9f
d0aa773
c327158
bea7d7e
b035289
3ef126c
971c0b3
1acaf80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,10 @@ example shows all possible fields, but note that only a few are required. | |
"command": [], | ||
"config": {} | ||
} | ||
}, | ||
"weights": { | ||
"passing": 5, | ||
"warning": 1 | ||
} | ||
} | ||
} | ||
|
@@ -151,6 +155,17 @@ are used to configure the proxy and are specified in the [proxy | |
docs](/docs/connect/proxies.html). If `native` is true, it is an error to also | ||
specifiy a managed proxy instance. | ||
|
||
The `weights` field is an optional field to specify the weight of a service in | ||
DNS SRV responses. If this field is not specified, its default value is: | ||
`"weights": {"passing": 1, "warning": 1}`. | ||
When a service is `critical`, it is excluded from DNS responses, `warning` services | ||
will be in DNS responses as well unless the `only_passing = true` is set in the | ||
DNS configuration of the agent. | ||
When DNS SRV requests are issued, response will include the weight in the SRV | ||
response accordingly to the state of service. It allows to put more weights | ||
on services running on larger nodes and optionnally to put less pressure on | ||
services being in `warning` state. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @banks DONE as well in next patch |
||
|
||
## Multiple Service Definitions | ||
|
||
Multiple services definitions can be provided at once using the plural | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this reads a little confusingly and might be interpreted backwards, instead we could simplify it into multiple sentences:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE