Address flakiness in command/exec tests #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
approved these changes
Aug 10, 2018
testrpc/wait.go
Outdated
| @@ -9,10 +9,10 @@ import ( | |||
|
|
|||
| type rpcFn func(string, interface{}, interface{}) error | |||
|
|
|||
| func WaitForLeader(t *testing.T, rpc rpcFn, dc string) { | |||
| // WaitForLeader ensures we have a leader and a node registration. | |||
| func WaitForLeader(t *testing.T, rpc rpcFn, dc, node string) { | |||
There was a problem hiding this comment.
This looks like maybe a leftover (unintentional) change - changing this function signature would affect a lot of tests and downstream things that pull in this package to test with, like consul-template and nomad.
There was a problem hiding this comment.
Good catch, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the command/exec tests were consistently flaky and reporting the following errors:
These are associated with a race between bootstrapping the test agent and actions like creating a session.
With the WaitForTestAgent helper function we now wait for the new node (and its check) to be registered in the catalog.
Also, there was some flakiness around the timeouts in TestExecCommand_StreamResults, so the channel reads were wrapped in retries.
After making all these changes the tests in command/exec have consistently passed in the repro environment.