Fix #4515: Segfault when serf_wan port was -1 but reconnect_time_wan was set #4531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banks
requested changes
Aug 15, 2018
agent/agent.go
Outdated
| base.SerfLANConfig.ReconnectTimeout = a.config.ReconnectTimeoutLAN | ||
| } | ||
|
|
||
| fmt.Println(a.config.SerfBindAddrWAN) |
There was a problem hiding this comment.
It certainly does. I had that there when I was trying to figure out why my test wasn't disabling WAN serf.
|
@banks I assume now that that println is gone you are good with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4515
This just slightly refactors the logic to only attempt to set the serf wan reconnect timeout when the rest of the serf wan settings are configured - thus avoiding a segfault.