fsm: add missing CA config to snapshot/restore logic #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Aug 16, 2018
There was a problem hiding this comment.
Everything here looks good.
I know its unrelated but I wonder if it would be useful to add a test for ensuring snapshotting/restoring of proxy configurations in this PR. We could always do it separately but its kind of a similar issue. I will leave it up to you and approve this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CA config not being backed up/restored from snapshots properly, which was causing issues when servers loaded the CA state from a snapshot and the roots didn't match the CA config (because the CA config was being re-initialized from the config instead of loaded from the snapshot).