-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log method failing when doing server/server RPC calls to help diagnose connectivity issues #4548
Merged
hanshasselberg
merged 1 commit into
hashicorp:master
from
pierresouchay:rpc_errors_more_logs
Jan 13, 2020
Merged
Log method failing when doing server/server RPC calls to help diagnose connectivity issues #4548
hanshasselberg
merged 1 commit into
hashicorp:master
from
pierresouchay:rpc_errors_more_logs
Jan 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierresouchay
changed the title
Log method failing when doing server/server RPC calls to help diagnos…
Log method failing when doing server/server RPC calls to help diagnose connectivity issues
Aug 21, 2018
@pierresouchay I like the change, are you still interested in adding that? |
yes :-) |
I promise. |
hanshasselberg
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your work!
hanshasselberg
added
the
waiting-reply
Waiting on response from Original Poster or another individual in the thread
label
Dec 16, 2019
Any updates? |
stale
bot
removed
the
waiting-reply
Waiting on response from Original Poster or another individual in the thread
label
Jan 13, 2020
hanshasselberg
added
the
waiting-reply
Waiting on response from Original Poster or another individual in the thread
label
Jan 13, 2020
…e connectivity issues Sometimes, we have lots of errors in cross calls between DCs (several hundreds / sec) Enrich the log in order to help diagnose the root cause of issue.
pierresouchay
force-pushed
the
rpc_errors_more_logs
branch
from
January 13, 2020 16:57
1cf01bf
to
f1fefe6
Compare
stale
bot
removed
the
waiting-reply
Waiting on response from Original Poster or another individual in the thread
label
Jan 13, 2020
@i0rek Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log method failing when doing server/server RPC calls to help diagnose connectivity issues
Sometimes, we have lots of errors in cross calls between DCs (several hundreds / sec)
Enrich the log in order to help diagnose the root cause of issue.