Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log method failing when doing server/server RPC calls to help diagnose connectivity issues #4548

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Log method failing when doing server/server RPC calls to help diagnose connectivity issues #4548

merged 1 commit into from
Jan 13, 2020

Conversation

pierresouchay
Copy link
Contributor

@pierresouchay pierresouchay commented Aug 21, 2018 •
edited
Loading

Log method failing when doing server/server RPC calls to help diagnose connectivity issues

Sometimes, we have lots of errors in cross calls between DCs (several hundreds / sec)
Enrich the log in order to help diagnose the root cause of issue.

@pierresouchay pierresouchay changed the title Log method failing when doing server/server RPC calls to help diagnos… Log method failing when doing server/server RPC calls to help diagnose connectivity issues Aug 21, 2018
@pierresouchay
Copy link
Contributor Author

@mkeeler @banks would help a lot troubleshooting connectivity issues and is quite simple

@pierresouchay pierresouchay mentioned this pull request Jun 3, 2019
Merged
@hanshasselberg
Copy link
Member

@pierresouchay I like the change, are you still interested in adding that?

@hanshasselberg hanshasselberg self-assigned this Dec 12, 2019
@pierresouchay
Copy link
Contributor Author

yes :-)
I you review it in the next 15 days, I'll rebase and make it work

@hanshasselberg
Copy link
Member

I promise.

hanshasselberg
hanshasselberg approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your work!

@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Dec 16, 2019
@hanshasselberg
Copy link
Member

Any updates?

@stale stale bot removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Jan 13, 2020
@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Jan 13, 2020
@pierresouchay
Log method failing when doing server/server RPC calls to help diagnos…
f1fefe6 
…e connectivity issues

Sometimes, we have lots of errors in cross calls between DCs (several hundreds / sec)
Enrich the log in order to help diagnose the root cause of issue.
@stale stale bot removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Jan 13, 2020
@pierresouchay
Copy link
Contributor Author

@i0rek Done

@hanshasselberg hanshasselberg merged commit 3bf2e64 into hashicorp:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees

@hanshasselberg hanshasselberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierresouchay @hanshasselberg