UI: Fixes healthy node listing resize on large portrait screens #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Split the resizing functionality of into a separate mixin to be shared across components 2. Add basic integration tests to prove that everything is getting called through out the lifetime of the app. I decided against unit testing as there isn't really any isolated logic to be tested, more checking that things are being called in the correct order etc i.e. the integration is correct.
DingoEatingFuzz
approved these changes
Aug 23, 2018
| const rect = $self.getBoundingClientRect(); | ||
| const $footer = [...$$('footer[role="contentinfo"]')][0]; | ||
| const space = rect.top + $footer.clientHeight; | ||
| const height = new Number(e.detail.height - space); |
There was a problem hiding this comment.
Why use the Number constructor here?
There was a problem hiding this comment.
Good question! Removed
| get(this, 'win').removeEventListener('resize', this.handler); | ||
| this._super(...arguments); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Nice mixin. One suggestion I have is to put emphasis on resize in some manner to make it obvious that that is the interesting part for a consumer of this mixin. This could be as simple as moving resize to the first thing in the file so it's hard to overlook, or something more aggressive like this, which throws an error if a component/controller/whatever is mixing in the mixin without overriding the expected method.
| innerWidth: 0, | ||
| innerHeight: 0, | ||
| addEventListener: this.stub(), | ||
| removeEventListener: this.stub(), |
There was a problem hiding this comment.
Neat. I need to look into ember-sinon-qunit. I'm just using plain sinon right now, but I love spies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4368
Split the resizing functionality of into a separate mixin to be shared across components