Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Bugfix. Fix code toggle in Safari #4608

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Aug 29, 2018

I'd mistakenly changed the checkbox event to listen to oninput, which
works in Chrome and Firefox. Changed this back to onchange as it should
be (hence a one word diff)

Fixes #4529

I'd mistakenly changed the checkbox event to listen to oninput, which
works in Chrome and Firefox. Changed this back to onchange as it should
be.
@johncowen johncowen requested a review from a team August 29, 2018 13:46
@johncowen johncowen added the theme/ui Anything related to the UI label Aug 29, 2018
Copy link
Collaborator

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 I don’t think I realized oninput doesn’t work in safari.

@johncowen
Copy link
Contributor Author

Cheers @meirish !

@johncowen johncowen merged commit 5e98796 into master Aug 30, 2018
@johncowen johncowen deleted the bugfix/gh-4549-code-toggle branch August 30, 2018 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants