Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: External Source markers #4640

Merged
merged 7 commits into from
Sep 12, 2018
Merged

UI: External Source markers #4640

merged 7 commits into from
Sep 12, 2018

Commits on Sep 6, 2018

  1. ui: External Source markers

    1. Addition of external source icons for services marked as such.
    2. New %with-tooltip css component (wip)
    3. New 'no healthcheck' icon as external sources might not have
    healthchecks
    4. If a service doesn't have healthchecks, then the [Health Checks] tab in
    the Service detail page is hidden, we use the [Services] tabs as the
    default instead
    5. `css-var` helper. The idea here is that it will eventually be
    replaced with pure css custom properties instead of having to use JS. It
    would be nice to be able to build the css variables into the JS at build
    time (you'd probably still want to specify in config which variables you
    wanted available in JS), but that's possible future work.
    
    Lastly there is probably a tiny bit more testing edits here than usual,
    I noticed that there was an area where the dynamic mocking wasn't
    happening, it was just using the mocks from consul-api-double, the mocks
    I was 'dynamically' setting happened to be the same as the ones in
    consul-api-double. I've fixed this here also but it wasn't effecting
    anything until actually made certain values dynamic.
    John Cowen committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    da49e23 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. ui: Tweak tooltip text for external sources

    John Cowen committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    cc441f2 View commit details
    Browse the repository at this point in the history
  2. ui: Continue to show the healthcheck tab but select the Services one

    When there are no checks, still show the healthchecks tab in the node
    detail page, but default to the Services tab. The healthcheck tab panel
    now shows a 'no healthchecks' message
    John Cowen committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    bf0f01f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddb6d7f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. Configuration menu
    Copy the full SHA
    9107485 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38eb8d6 View commit details
    Browse the repository at this point in the history
  3. ui: Add the text of the tooltip to the textContent of the page

    It's now only a tooltip because the design says so, which I would guess
    would make for a better a11y experience
    John Cowen committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    523323b View commit details
    Browse the repository at this point in the history