Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Turn off the KV code editor whilst making an edit during testing #4668

Merged
merged 1 commit into from
Sep 20, 2018
Merged

ui: Turn off the KV code editor whilst making an edit during testing #4668

merged 1 commit into from
Sep 20, 2018

Conversation

johncowen
Copy link
Contributor

Having the code editor on removes the text area from the DOM, making it
more difficult to enter text in the text editor during testing. This
turns the code editor off whilst making edits during testing.

No changes to UI code

ui: Turn off the code editor whilst making an edit during testing
3ef3fd0 
Having the code editor on removes the text area from the DOM, making it
more difficult to enter text in the text editor during testing. This
turns the code editor off whilst making edits during testing.

No changes to UI code
@johncowen johncowen added the theme/ui Anything related to the UI label Sep 13, 2018
@johncowen johncowen requested review from a team and pearkes September 13, 2018 08:30
@johncowen johncowen changed the title ui: Turn off the code editor whilst making an edit during testing ui: Turn off the KV code editor whilst making an edit during testing Sep 13, 2018
DingoEatingFuzz
DingoEatingFuzz approved these changes Sep 20, 2018
View reviewed changes
Copy link

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a sufficient change for what you want.

If you'd like to use the code editor down the road, I wrote some test helpers for interacting with CodeMirror instances.

@johncowen
Copy link
Contributor Author

Ah super handy! Thanks!

I'm gonna merge this down for now as I want to get rid of my red, but I'll be updating things soon to add tests for codemirror also based on what you've linked to, will ping you in the PR.

Ta

@johncowen johncowen merged commit 89620b9 into master Sep 20, 2018
@johncowen johncowen deleted the bugfix/test-unset-kv-code-editor branch September 20, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DingoEatingFuzz DingoEatingFuzz DingoEatingFuzz approved these changes

@pearkes pearkes Awaiting requested review from pearkes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncowen @DingoEatingFuzz