UI: Use buttons instead of anchors where appropriate #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshasselberg
approved these changes
Nov 16, 2018
johncowen
added a commit
that referenced
this pull request
Nov 26, 2018
Use buttons instead of anchors where appropriate
Merged
johncowen
added a commit
that referenced
this pull request
Dec 5, 2018
Use buttons instead of anchors where appropriate
johncowen
added a commit
that referenced
this pull request
Jan 28, 2019
Use buttons instead of anchors where appropriate
johncowen
added a commit
that referenced
this pull request
Feb 21, 2019
Use buttons instead of anchors where appropriate
johncowen
added a commit
that referenced
this pull request
Apr 29, 2019
Use buttons instead of anchors where appropriate
johncowen
added a commit
that referenced
this pull request
May 1, 2019
Use buttons instead of anchors where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few call to actions that were anchors are better as buttons. These are all inside the 'action-groups' (the dropdown menus at the end of the rows)
P.S. Found a comment that mentions this referenced below but also adding here in case I miss it later down the line.
#4789 (comment)