Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: document and viewport dom service additions #4994

Merged
merged 1 commit into from
Dec 4, 2018
Merged

UI: document and viewport dom service additions #4994

merged 1 commit into from
Dec 4, 2018

Commits on Nov 26, 2018

  1. ui: Adds document and viewport methods to the dom service 

    `window` and `document` are easily injected anyhow, but this
primarily this keeps everything dom related in the same place.

Included here are changes to make all ember related objects use the dom
service `document` and `viewport` instead of just `document` and
`window`.

Quote from a previous PR (#4924) which explains the thinking around this:

> Now I have all these things in the dom service, it would make sense
to get window from there also. I was thinking of making a viewport
method, which would be a nice word whether window was a browser window,
an iframe (not really a window) like when ember testing, or anything
else. To me the viewport is what we are actually talking about here.
    John Cowen committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    3ae9913 View commit details
    Browse the repository at this point in the history