Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for maximum size for Output of checks #5233

Merged
merged 14 commits into from
Jun 26, 2019
Merged

Support for maximum size for Output of checks #5233

merged 14 commits into from
Jun 26, 2019

Commits on May 10, 2019

  1. Support for maximum size for Output of checks 

    This PR will allow administrator to limit the size of Output produced by healthchecks,
when set at agent level, it will be the maximum output for all healthchecks produced
by agents.

It will also allow specific healthchecks to go below the limit set by administrator,
OutputMaxSize if set in check specification will now allow to go beyond agent level
setting, but will allow to reduce it further.

We had the following configuration  at agent level
 * check_output_max_size (default: 4k) : max number for all checks of the agent
 * check.OutputMaxSize: (default: 4k)
    @pierresouchay
    pierresouchay committed May 10, 2019
    Configuration menu
    Copy the full SHA
    6c21464 View commit details
    Browse the repository at this point in the history

  2. Added unit test

    @pierresouchay
    pierresouchay committed May 10, 2019
    Configuration menu
    Copy the full SHA
    b5717aa View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Fixed code comments from @freddygv 

    * Renamed `checks.BufSize` to `checks.DefaultBufSize`
* Use the constant where appropriate
* Better error message when `check_output_max_size` has wrong value
    @pierresouchay
    pierresouchay committed May 22, 2019
    Configuration menu
    Copy the full SHA
    b5f00ff View commit details
    Browse the repository at this point in the history

  2. Added documentation for OutputMaxSize and check_output_max_size

    @pierresouchay
    pierresouchay committed May 22, 2019
    Configuration menu
    Copy the full SHA
    79a02fa View commit details
    Browse the repository at this point in the history

  3. Fixed errors in HCL for some unit tests in runtime_test.go

    @pierresouchay
    pierresouchay committed May 22, 2019
    Configuration menu
    Copy the full SHA
    8dcf910 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Update website/source/docs/agent/options.html.md 

    suggestion from @freddygv

Co-Authored-By: Freddy <freddygv@users.noreply.github.com>
    @pierresouchay @freddygv
    pierresouchay and freddygv authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    bc0ace6 View commit details
    Browse the repository at this point in the history

  2. Update agent/config/flags.go 

    suggestion from @freddygv

Co-Authored-By: Freddy <freddygv@users.noreply.github.com>
    @pierresouchay @freddygv
    pierresouchay and freddygv authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    a684019 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Updated doc

    @pierresouchay
    pierresouchay committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    89b5a23 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Ensure TTL HealthChecks are properly truncated everywhere

    @pierresouchay
    pierresouchay committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0a95339 View commit details
    Browse the repository at this point in the history

  2. Update website/source/api/agent/check.html.md 

    suggestion from @freddygv

Co-Authored-By: Freddy <freddygv@users.noreply.github.com>
    @pierresouchay @freddygv
    pierresouchay and freddygv authored Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2b3df47 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Properly truncate TTL checks 

    Check that OutputMaxSize is properly taken into account.

BUGFIX: properly update local state on update of TTL
    @pierresouchay
    pierresouchay committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    a68ecd0 View commit details
    Browse the repository at this point in the history

  2. No silent error when state of check TTL does not exist in agent

    @pierresouchay
    pierresouchay committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    acce4eb View commit details
    Browse the repository at this point in the history

  3. Check that check_output_max_size is enforced properly

    @pierresouchay
    pierresouchay committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    13710da View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Truncation of TTL check at proper place aka before notification

    @pierresouchay
    pierresouchay committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    8478180 View commit details
    Browse the repository at this point in the history