Move autopilot initialization to prevent race

[mkeeler]

establishLeadership invoked during leadership monitoring may use autopilot to do promotions etc. There was a race with doing that and having autopilot initialized and this fixes it.

[hanshasselberg]

I was curious what exactly happens. monitorLeadership starts leaderLoop:

consul/agent/consul/leader.go

Lines 73 to 77 in 2afc2a3

	leaderLoop.Add(1)
	go func(ch chan struct{}) {
	defer leaderLoop.Done()
	s.leaderLoop(ch)
	}(weAreLeaderCh)

And in leaderLoop we call establishLeadership:

consul/agent/consul/leader.go

Line 170 in d7e4151

if err := s.establishLeadership(); err != nil {

Which finally tries to use autopilot:

consul/agent/consul/leader.go

Line 265 in d7e4151

s.autopilot.Start()

[hanshasselberg]

👍