Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hang Envoy when result set is empty #5384

Closed
wants to merge 1 commit into from
Closed

Don't hang Envoy when result set is empty #5384

wants to merge 1 commit into from

Commits on Feb 25, 2019

  1. Don't hang Envoy when result set is empty 

    As noted in #4868 we can sometimes cause Envoy to hang if one or more upstream has no instances available since Envoy won't continue processing xDS for listeners until it has all the endpoints resolved they'd be proxying to.

I _assume_ that this is correct and that by getting an explicit empty result Envoy will continue to resolve the config and just fail with a 503 if that upstream is connected.

This needs testing though and also ensuring that it doesn't cause any other side-effects.
    @banks
    banks authored Feb 25, 2019
    Configuration menu
    Copy the full SHA
    460a2de View commit details
    Browse the repository at this point in the history