Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont modify memdb owned token data for get/list requests of tokens #5412

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Dont modify memdb owned token data for get/list requests of tokens #5412

merged 1 commit into from
Mar 4, 2019

Commits on Mar 1, 2019

  1. Dont modify memdb owned token data for get/list requests of tokens 

    Previously we were fixing up the token links directly on the *ACLToken returned by memdb. This invalidated some assumptions that a snapshot is immutable as well as potentially being able to cause a crash.

The fix here is to give the policy link fixing function copy on write semantics. When no fixes are necessary we can return the memdb object directly, otherwise we copy it and create a new list of links.

Eventually we might find a better way to keep those policy links in sync but for now this fixes the issue.
    @mkeeler
    mkeeler committed Mar 1, 2019
    Configuration menu
    Copy the full SHA
    8e51da7 View commit details
    Browse the repository at this point in the history