Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add ip addresses as Subject Alternative Names when creating certificates #5602

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Allow to add ip addresses as Subject Alternative Names when creating certificates #5602

merged 2 commits into from
Apr 4, 2019

Conversation

tristan-weil
Copy link
Contributor

Fixes #5601

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 3, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hanshasselberg
hanshasselberg requested changes Apr 3, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Found two nitpicks, looks great otherwise! 👍

hanshasselberg
hanshasselberg approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hanshasselberg hanshasselberg merged commit fe938e6 into hashicorp:master Apr 4, 2019
@tristan-weil tristan-weil deleted the tls_cert_ipaddresses branch April 4, 2019 13:15
@pearkes pearkes mentioned this pull request Apr 25, 2019
Closed
@tristan-weil tristan-weil mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cert: additional ip addresses in SANs
3 participants
@tristan-weil @hashicorp-cla @hanshasselberg