Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Reconcile ember-data store when records are deleted via blocking #5745

Merged
merged 2 commits into from
May 15, 2019
Merged

ui: Reconcile ember-data store when records are deleted via blocking #5745

merged 2 commits into from
May 15, 2019

Commits on May 15, 2019

  1. ui: Reconciliate ember-data store when records are deleted via blocking 

    Currently we are barely using the ember-data store/cache, but it will
still cache records in the store even though technically we aren't using
it.

This adds a SyncTime to every record that uses blocking queries so we
can delete older records from the ember-data cache to prevent them
building up
    John Cowen committed May 15, 2019
    Configuration menu
    Copy the full SHA
    867db24 View commit details
    Browse the repository at this point in the history

  2. ui: Add basic timestamp method we can access from tests, fixup tests 

    Adds a timestamp method that we can access from within tests so we can
test that the SyncTime is being set.

There is probably a better way to do this, but this is also probably the
simplest approach - we are also likely to revisit this at a later date
    John Cowen committed May 15, 2019
    Configuration menu
    Copy the full SHA
    8a1f849 View commit details
    Browse the repository at this point in the history