Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfigEntryResponse binary marshaller and ensure we watch the chan in ConfigEntry.Get even when no entry exists. #5773

Merged
merged 4 commits into from
May 2, 2019
Merged

Fix ConfigEntryResponse binary marshaller and ensure we watch the chan in ConfigEntry.Get even when no entry exists. #5773

merged 4 commits into from
May 2, 2019

Commits on May 2, 2019

  1. Fix ConfigEntryResponse binary marshaller 

    This was quitely having a nil pointer deref
    @mkeeler
    mkeeler committed May 2, 2019
    Configuration menu
    Copy the full SHA
    29aa7a7 View commit details
    Browse the repository at this point in the history

  2. Add tests for marshalling the ConfigEntryResponse

    @mkeeler
    mkeeler committed May 2, 2019
    Configuration menu
    Copy the full SHA
    8db0047 View commit details
    Browse the repository at this point in the history

  3. Make sure to still watch the chan even when it doesn’t exist

    @mkeeler
    mkeeler committed May 2, 2019
    Configuration menu
    Copy the full SHA
    d965aaa View commit details
    Browse the repository at this point in the history

  4. Don’t encode the nil entry at all

    @mkeeler
    mkeeler committed May 2, 2019
    Configuration menu
    Copy the full SHA
    af2abc6 View commit details
    Browse the repository at this point in the history