Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: validate and test more of the L7 config entries #6156

Merged
merged 3 commits into from
Jul 24, 2019
Merged

connect: validate and test more of the L7 config entries #6156

merged 3 commits into from
Jul 24, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jul 17, 2019

No description provided.

@rboyer rboyer added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Jul 17, 2019
@rboyer rboyer added this to the 1.6.0-beta3 milestone Jul 17, 2019
@rboyer rboyer requested a review from a team July 17, 2019 19:06
@rboyer rboyer self-assigned this Jul 17, 2019
@rboyer rboyer force-pushed the l7-config-and-validate branch from 189838c to e31f8aa Compare July 17, 2019 20:32
banks
banks approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on an error string that could maybe use a tweak but LGTM otherwise

agent/structs/config_entry_discoverychain.go Outdated Show resolved Hide resolved
agent/structs/config_entry_discoverychain.go

// validateServiceSubset checks if the provided name can be used as an service
// subset. Because these are used in SNI headers they must a DNS label per
// RFC-1035/RFC-1123.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rboyer rboyer force-pushed the l7-config-and-validate branch from 6ad6634 to 53a1050 Compare July 24, 2019 00:55
@rboyer rboyer merged commit 1dbd92e into release/1-6 Jul 24, 2019
@rboyer rboyer deleted the l7-config-and-validate branch July 24, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

Assignees

@rboyer rboyer

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Milestone
1.6.0-beta3
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @banks