Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: update dependencies #616

Merged
merged 2 commits into from
Jan 20, 2015
Merged

Makefile: update dependencies #616

merged 2 commits into from
Jan 20, 2015

Conversation

ceh
Copy link
Contributor

@ceh ceh commented Jan 17, 2015

Build failed for me due to github.com/hashicorp/serf/serf not
being up to date.

$ make
[...]
--> Installing dependencies to speed up builds...
# github.com/hashicorp/serf/serf
../serf/serf/serf.go:354: conf.MemberlistConfig.Merge undefined (type *memberlist.Config has no field or method Merge)

Add the -u flag to go get when downloading build dependencies to always use the tip.

@ryanuber
Copy link
Member

Thanks, @ceh! Are two -f's required in the go get command?

Prevent build failures which may occur when dependencies is
not up to date by updating them with the go get -u flag.

Add the go get -f flag as well, to override the check that
each package has been checked out from the repo implied by
its import path.
@ceh
Copy link
Contributor Author

ceh commented Jan 18, 2015

@ryanbreen No, thanks for noticing. Rebased, fixup and forced push.

armon added a commit that referenced this pull request Jan 20, 2015
Makefile: update dependencies
@armon armon merged commit 1154b0c into hashicorp:master Jan 20, 2015
@armon
Copy link
Member

armon commented Jan 20, 2015

Thanks!

@ceh ceh deleted the updatedeps branch January 20, 2015 06:49
duckhan pushed a commit to duckhan/consul that referenced this pull request Oct 24, 2021
tar is required for kubectl cp to work and it's also included by default
in our regular images through Alpine so makes sense to have it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants