fix(connect/proxy): remove h2 from NextProtos #6235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the proxy used to announce that it supports http/2, which is not really the case. Especially it made the native SDK think that the upstream app also supports it, which broke support for every http/1.1 or older apps.
|
|
|
Hej, would be awesome if sb could take a look or hint me in another direction if needed. |
|
This is no longer an issue because the builtin proxy is no longer part of consul and envoy should be able to do the correct thing. |
|
Well, the managed proxies were removed, but not the builtin proxy. Sorry! |
|
Thanks for you work @sh0rez! I think the solution we have in mind is a little different: #4466 (comment). Would you be interested in giving that a try? |
hanshasselberg
added
the
waiting-reply
|
Closing because no reply. I am happy to reopen in case there are updates. Thanks! |
ghost
removed
the
waiting-reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the proxy used to announce that it supports http/2, which is not really
the case. Especially it made the native SDK think that the upstream app also
supports it, which broke support for every http/1.1 or older apps.
This has been solved adding a function to the SDK to obtain a Service without
http/2enabled.The proxy switches to this from now, disabling
http/2support. This is not configurable, because I was unable to find a place to put this, without mixing L4 and L7 handling.Feedback welcome :)
Fixes #4466