Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: error from KVS endpoint if incompatible flags are passed. #634

Merged
merged 1 commit into from
Jan 23, 2015

Conversation

ryanuber
Copy link
Member

This disambiguates behavior of the KVS endpoint when conflicting arguments are passed. As an example, providing ?cas and ?acquire during a PUT does not actually do both operations, and it is not clear which operation actually happens when it succeeds. This will make such requests return a 400.

Fixes #432

@armon
Copy link
Member

armon commented Jan 23, 2015

LGTM!

ryanuber added a commit that referenced this pull request Jan 23, 2015
agent: error from KVS endpoint if incompatible flags are passed.
@ryanuber ryanuber merged commit 0bfffd4 into master Jan 23, 2015
@ryanuber ryanuber deleted the f-httpargs-conflict branch January 23, 2015 21:13
duckhan pushed a commit to duckhan/consul that referenced this pull request Oct 24, 2021
* Add support for L4 intentions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simultaneous acquisition of kv session lock and atomic update succeeds regardless of modifyIndex
2 participants