Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Add server raft.{last,applied}_index gauges #6694

Merged
merged 1 commit into from
Feb 11, 2020
Merged

[Metrics] Add server raft.{last,applied}_index gauges #6694

merged 1 commit into from
Feb 11, 2020

Conversation

ShimmerGlass
Copy link
Contributor

These metrics are useful for :

  • Tracking te rate of update to the db
  • Allow to have a rough idea of when an index originated

[Metrics] Add server raft.{last,applied}_index gauges
54ba99a 
These metrics are useful for :
* Tracking te rate of update to the db
* Allow to have a rough idea of when an index originated
pierresouchay
pierresouchay approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@pierresouchay pierresouchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, really useful for us, since the gauge would help us see constant differences between servers and even have an idea about the time a given index has been applied

hanshasselberg
hanshasselberg approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@hanshasselberg hanshasselberg merged commit 68e0f6b into hashicorp:master Feb 11, 2020
@ShimmerGlass ShimmerGlass deleted the raft-metrics branch February 11, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

@pierresouchay pierresouchay pierresouchay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShimmerGlass @hanshasselberg @pierresouchay