sdk: add NewTestServerT, deprecate NewTestServer #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent nil pointer deref from t.Logf usage
rboyer
reviewed
Nov 8, 2019
mikemorris
changed the title
mikemorris
added a commit
that referenced
this pull request
Nov 8, 2019
mikemorris
added a commit
that referenced
this pull request
Nov 8, 2019
* prevent nil pointer deref from t.Logf usage * enforce non-nil *testing.T in NewTestServerT
mikemorris
added a commit
that referenced
this pull request
Nov 8, 2019
|
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent nil pointer deref from
t.Logfusage.Looks like this had been worked around previously by adding a nil check in 6d4930d, but this formally deprecates the problematic method.