Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give feedback to CLI user on forceleave command if node does not exist #6841

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

s-mang
Copy link
Contributor

@s-mang s-mang commented Nov 26, 2019

No description provided.

@s-mang s-mang requested a review from a team November 26, 2019 19:34
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach looks good @adams-sarah, thanks for taking care of this. I added a comment and a request inline.

Lastly, some tests need to be updated since the CI test failures are related to these changes. A few tests didn't create a node before issuing a ForceLeave request, so now they're getting an error because of it.

command/forceleave/forceleave_test.go Outdated Show resolved Hide resolved
agent/agent.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #6841 into master will increase coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6841      +/-   ##
==========================================
+ Coverage   65.79%   65.82%   +0.02%     
==========================================
  Files         435      435              
  Lines       52405    52412       +7     
==========================================
+ Hits        34482    34501      +19     
+ Misses      13787    13782       -5     
+ Partials     4136     4129       -7
Impacted Files Coverage Δ
agent/agent.go 67.64% <57.14%> (-0.04%) ⬇️
api/session.go 66.07% <0%> (-5.36%) ⬇️
agent/cache/cache.go 78.82% <0%> (-1.57%) ⬇️
agent/kvs_endpoint.go 80.12% <0%> (-1.29%) ⬇️
agent/consul/connect_ca_endpoint.go 56.52% <0%> (-0.67%) ⬇️
api/lock.go 80.72% <0%> (-0.61%) ⬇️
agent/consul/acl.go 87.85% <0%> (-0.11%) ⬇️
agent/config/builder.go 83.48% <0%> (+0.08%) ⬆️
agent/consul/acl_endpoint.go 57.52% <0%> (+0.15%) ⬆️
agent/consul/acl_server.go 67.7% <0%> (+1.04%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dbf7f...c48709e. Read the comment docs.

Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! LGTM

@s-mang s-mang merged commit aed5cb7 into master Dec 2, 2019
@s-mang s-mang deleted the forceleave-feedback-node-dne branch December 2, 2019 19:06
@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants