Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Explicitly remove properties that shouldn't be sent when saving #6917

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

johncowen
Copy link
Contributor

This PR removes properties that shouldn't be sent when saving objects back to the API. Previously Consul would allow this but a recent change disallowed it (#6874)

@johncowen johncowen requested review from mkeeler and a team December 10, 2019 15:23
@johncowen johncowen added the theme/ui Anything related to the UI label Dec 10, 2019
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit 5a88d4e into master Dec 10, 2019
@johncowen johncowen deleted the bugfix/ui-token-saving branch December 10, 2019 15:47
@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants