Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rate limiting applies to Consul agents in server mode #6932

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

stuwil
Copy link
Contributor

@stuwil stuwil commented Dec 11, 2019

1.5.2 included #5927, which started enforcing configured rate limits on Consul agents running in server mode. This updates the configuration documentation to actually state that.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 11, 2019

CLA assistant check
All committers have signed the CLA.

@stuwil stuwil changed the title Rate limiting applies to Consul agents in server mode docs: Rate limiting applies to Consul agents in server mode Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #6932 into master will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6932      +/-   ##
==========================================
+ Coverage   65.23%   65.63%   +0.39%     
==========================================
  Files         458      443      -15     
  Lines       55102    53292    -1810     
==========================================
- Hits        35947    34979     -968     
+ Misses      14872    14090     -782     
+ Partials     4283     4223      -60
Impacted Files Coverage Δ
agent/connect/common_names.go 21.62% <0%> (-27.54%) ⬇️
agent/consul/state/index_service_kind.go 25% <0%> (-25%) ⬇️
command/tls/cert/create/tls_cert_create.go 50.79% <0%> (-14.25%) ⬇️
command/agent/agent.go 47.43% <0%> (-6.6%) ⬇️
agent/consul/enterprise_client_oss.go 50% <0%> (-5.56%) ⬇️
lib/patch_hcl.go 57.44% <0%> (-5.52%) ⬇️
command/monitor/monitor.go 56% <0%> (-5.41%) ⬇️
agent/consul/intention_endpoint.go 67.68% <0%> (-3.36%) ⬇️
command/connect/envoy/envoy.go 44.79% <0%> (-2.29%) ⬇️
agent/http_oss.go 50% <0%> (-2.18%) ⬇️
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40b9f3...5fd6761. Read the comment docs.

Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@hanshasselberg
Copy link
Member

Could you rebase your changes so that I can merge your PR?

@hanshasselberg hanshasselberg self-assigned this Feb 3, 2020
@hanshasselberg hanshasselberg added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 3, 2020
@stuwil stuwil force-pushed the ratelimiting-docs branch from 3b835c5 to 5fd6761 Compare February 3, 2020 11:56
@stuwil
Copy link
Contributor Author

stuwil commented Feb 3, 2020

@i0rek you've got it!

@ghost ghost removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Feb 3, 2020
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hanshasselberg hanshasselberg merged commit 3eb7669 into hashicorp:master Feb 3, 2020
@stuwil stuwil deleted the ratelimiting-docs branch February 12, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants