ui: New Confirmation Dialogs #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
theme/ui
johncowen
force-pushed
the
feature/ui-reuse-popup-menu
branch
2 times, most recently
from
81635c5
to
b89272b
Compare
added 6 commits
January 16, 2020 11:08
johncowen
force-pushed
the
feature/ui-reuse-popup-menu
branch
from
d983820
to
538d113
Compare
kaxcode
approved these changes
Jan 16, 2020
|
Yey, thanks @kaxcode ! I'm going to branch off from here to implement the new dialogs in the other areas we need them, once thats done I'll merge here and then finally merge both down to |
* ui: Implement new confirmation dialogs in other list views This includes another amend to the popover-menu in order to allow mutiple confirmations/subpanels in the same popover menu. The functionality added here to allow this is likely to change in the future.
|
I merged #7080 in here, everything is still passing and I tried it out some more, so I'm gonna merge this down onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is changes our old inline confirmation dialogs to use a new style in the intention listing only (to provide context/preview).
Preview Link
Additional work on top of this will include implementing this into our other list views, currently they are completely broken so this PR should not be merged until that work is completed.
We reused our work from the namespace/dc menu here, but we've specifically disabled the keyboard navigation on these dialogs for the moment, we plan on getting this into a release before working further on the keyboard functionality here.
Also included here is a different approach to managing our z-indexing in our list views, this approach massively simplifies our previous approach and means we have to overwrite far less of the methods of the parent component.Turns out zIndexing remained problematic. But preferably we wanted to keep things simpler than the old approach, although unfortunately we still need to delve into
ember-collectionto be able to maintain correct zIndexing. The approach is simpler but hackier, but this is preferable to the old approach of duplicating all the code from theember-collectionaddon. We did have a quick think as to whether we could make a child class ofGridso it was less hacky but as we can't control the arguments that get passed toformatItemStyleit that wouldn't help us here. The result of all this is in d983820