Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security fixes #7182

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Security fixes #7182

merged 2 commits into from
Jan 31, 2020

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Jan 30, 2020 •
edited
Loading

See #7159 and #7160. These are the fixes for master.

@hanshasselberg hanshasselberg self-assigned this Jan 30, 2020
@hanshasselberg hanshasselberg requested a review from a team January 30, 2020 20:56
mkeeler
mkeeler approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkeeler
mkeeler requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, however the test failures would indicate otherwise. Some are from the new tests

@hanshasselberg
Copy link
Member Author

Tests are green now 🎉 (I didn't do anything though :()

@hanshasselberg
Copy link
Member Author

hanshasselberg commented Jan 31, 2020 •
edited
Loading

Ran twice without problems (or unrelated problems)

mkeeler
mkeeler approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mkeeler mkeeler merged commit 5531678 into master Jan 31, 2020
@mkeeler mkeeler deleted the security_fixes branch January 31, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees

@hanshasselberg hanshasselberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanshasselberg @mkeeler @banks