Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Discovery chain improvements #7222

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Feb 5, 2020

This PR includes several minor amends/improvement to the discovery chain visualization:

  1. We decided default wasn't the ideal word to use for the final catch-all route/the one that sometimes is added by default - so we reverted this one back to just using Prefix: /
  2. Various safer/defensive checks for a few things that we don't think is actually possible (the default router not being able to find a splitter/resolver, the disco-chain component firing an inViewport twice in a row with the same value etc.)
  3. We found a very weird templating potential bug where the entire visualisation would flash when appearing (render twice in quick succession), it seemed to be related to the fact that we were using if chain,. I never completely got to the bottom of why this was happening, but found that changing it to if (not-eq chain null) prevented the flashing from happening.
  4. As the bug in point 3 ^ sometimes rendered the entire chain twice, we'd occasionally get a bug due to the fact that we were mutating the data and therefore performing the same transformation on already transformed data. So we made the data use a more immutable state where this was happening.

Also took the opportunity to clean up a bit of our whitespace in the template while I was here.

@johncowen johncowen added the theme/ui Anything related to the UI label Feb 5, 2020
@johncowen johncowen requested a review from a team February 5, 2020 18:20
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johncowen johncowen merged commit ad3b532 into ui-staging Feb 6, 2020
@johncowen johncowen deleted the feature/ui-more-disco-chain-tweaks branch February 6, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants